Skip to content

Remove KOLLA_COPY_STRATEGY as COPY_ALWAYS is the default now #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove KOLLA_COPY_STRATEGY as COPY_ALWAYS is the default now #807

wants to merge 1 commit into from

Conversation

@mrkisaolamb
Copy link
Contributor

@mrkisaolamb mrkisaolamb commented Jun 28, 2024

Closes #707

@openshift-ci openshift-ci bot requested review from SeanMooney and lewisdenny June 28, 2024 14:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SeanMooney
SeanMooney requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cant do this until we update tcib

https://github.com/openstack-k8s-operators/tcib/blob/main/container-images/kolla/base/set_configs.py#L371-L386

they did not follow kolla lead in the fork.

we still need to set this today.

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Jun 28, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/839c837f37d54d179523ee89eda3e47c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 30s
❌ nova-operator-kuttl FAILURE in 50m 15s
❌ nova-operator-tempest-multinode FAILURE in 1h 16m 01s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 16m 12s

bogdando
bogdando reviewed Jun 4, 2025
View reviewed changes
Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the above concern about forked Kolla in TCIB, is this change request still relevant @mrkisaolamb
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdando bogdando bogdando left review comments

@SeanMooney SeanMooney SeanMooney requested changes

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

Assignees

@SeanMooney SeanMooney

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove KOLLA_COPY_STRATEGY as COPY_ALWAYS is the default now

3 participants

@mrkisaolamb @SeanMooney @bogdando